Skip to content

Conversation

@kaustuvpokharel
Copy link
Contributor

@kaustuvpokharel kaustuvpokharel commented Oct 7, 2025

Fixed:
Component was missing emptyDelegate condition, which not fixed with "no items" text as a emptyDelegateState when no features are present on the list.
Added padding to match figma design
Added drawer bottom margin

Screenshot 2025-10-07 at 11 59 31 PM

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Pull Request Test Coverage Report for Build 18399934587

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3766 unchanged lines in 30 files lost coverage.
  • Overall coverage decreased (-0.09%) to 19.566%

Files with Coverage Reduction New Missed Lines %
build-mm-db/vcpkg_installed/x64-linux/include/Qt6/QtCore/qfunctionaltools_impl.h 1 80.0%
mm/app/attributes/attributecontroller.cpp 1 76.83%
mm/app/attributes/attributepreviewcontroller.h 1 50.0%
build-mm-db/app/Input_autogen/EWIEGA46WW/moc_activeproject.cpp 2 31.84%
build-mm-db/core/mm_core_autogen/EWIEGA46WW/moc_merginapi.cpp 3 44.77%
mm/app/main.cpp 3 35.54%
build-mm-db/vcpkg_installed/x64-linux/include/Qt6/QtCore/qvariant.h 4 66.22%
build-mm-db/app/.rcc/qmlcache/Input_qmlcache_loader.cpp 8 94.0%
build-mm-db/app/Input_autogen/7HEK2XT3N7/moc_testactiveproject.cpp 9 43.75%
build-mm-db/app/Input_autogen/7HEK2XT3N7/moc_testattributepreviewcontroller.cpp 9 41.94%
Totals Coverage Status
Change from base Build 18221222417: -0.09%
Covered Lines: 13864
Relevant Lines: 70856

💛 - Coveralls

@kaustuvpokharel kaustuvpokharel linked an issue Oct 8, 2025 that may be closed by this pull request
@kaustuvpokharel kaustuvpokharel marked this pull request as ready for review October 8, 2025 04:08
@tomasMizera
Copy link
Collaborator

We'll ship this in 2025.8.0 instead

@kaustuvpokharel
Copy link
Contributor Author

kaustuvpokharel commented Oct 10, 2025

@tomasMizera tomasMizera changed the base branch from dev/2025.7.0 to dev/2025.8.0 October 10, 2025 11:48
@Withalion Withalion changed the base branch from dev/2025.8.0 to master November 11, 2025 10:00
@gabriel-bolbotina gabriel-bolbotina self-assigned this Nov 20, 2025
@Withalion Withalion linked an issue Dec 8, 2025 that may be closed by this pull request
@tomasMizera tomasMizera changed the title Fix: spacing for empty value relation fields Add empty state for value map/relation Dec 12, 2025
@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Dec 15, 2025
@github-actions
Copy link

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📭 Build not yet complete or failed.
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 artifact Expires: 16/03/2026 #5335
Android Build 📬 Mergin Maps 745211 APK [armeabi-v7a] Expires: 16/03/2026 #7452
Android Build 📬 Mergin Maps 745251 APK [arm64-v8a] Expires: 16/03/2026 #7452
iOS Build 📬 Build number: 25.12.839311 #8393

@Withalion Withalion removed the FROZEN 🥶 do not merge before upcoming release label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close (X) button unresponsive Improve spacing for empty value relation fields

5 participants