Skip to content

Conversation

@harminius
Copy link
Contributor

@harminius harminius commented Oct 2, 2025

Fixes: #679

  1. Unify social icons with the marketing web. Add missing socials, rm twitter.
  2. Replace paths with .svg files.
  3. External SVGs loaded via <img> cannot be styled with dynamic currentColor, so we inline SVGs by importing them as raw strings
  4. Github removed from the top banner
image

Copy link
Contributor

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's ok to use html injecting here.

  • please try to build this branch on dev.merginmaps.com/docs with pipeline and see if everyting is ok by build.

/>
</svg>
</span>
<a :href="href" target="_blank" rel="noopener">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave aria-label here

@harminius harminius changed the title Draft: Add missing socials, rm twitter Unify socials with marketing web Oct 2, 2025
@MarcelGeo
Copy link
Contributor

MarcelGeo commented Oct 2, 2025

I see that logo of mergin maps is not visible if dark mode.

@harminius
Copy link
Contributor Author

I see that logo of mergin maps is not visible if dark mode.

probably some bad cache/loading

image

@MarcelGeo MarcelGeo merged commit 7936fee into main Oct 8, 2025
5 of 6 checks passed
@MarcelGeo MarcelGeo deleted the unify_socials_with_marketing_web branch October 8, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify social links icons with marketing web merginmaps.com

3 participants