-
Notifications
You must be signed in to change notification settings - Fork 10
Replace gt dependency with lt #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yihui
wants to merge
12
commits into
main
Choose a base branch
from
replace-gt-with-lt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cc714fd
Replace gt dependency with lt
yihui 836d523
Add as_lt() documentation; update roxygen metadata
yihui 6b09388
Fix unquoted column names in lt_spanner() calls
yihui f860404
Add Remotes: yihui/lt for CI installation
yihui 1cf4873
Update _pkgdown.yml: as_gt -> as_lt
yihui 2d91429
Deprecate as_gt(); style as_lt() to match gt appearance
yihui 96062d2
Merge remote-tracking branch 'origin/main' into replace-gt-with-lt
yihui 93a5296
Add as_gt to pkgdown reference index
yihui 059a19a
Trim gt-style.css to only what differs from lt.css
yihui bd3bedf
Simplify as_gt() docs to a deprecation pointer
yihui 7fe511c
Use lt's bundled lt-gt.css theme instead of a local copy
yihui 9bd6d86
Drop lt_gt_style(); gt-like look is now lt's default
yihui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
as_gt()is an exported function, should we have at least one release where it is marked as deprecated before we actually remove it?