fix: Add Unicode sanitization for cloud embedders#1048
Open
anatolykoptev wants to merge 1 commit intoMemTensor:mainfrom
Open
fix: Add Unicode sanitization for cloud embedders#1048anatolykoptev wants to merge 1 commit intoMemTensor:mainfrom
anatolykoptev wants to merge 1 commit intoMemTensor:mainfrom
Conversation
15b1f1c to
6404af2
Compare
- Add _sanitize_unicode() function to remove surrogates - Apply sanitization before all embedding API calls - Add comprehensive tests for Unicode handling Fixes production crashes with VoyageAI/OpenAI when texts contain emoji or Unicode surrogates (U+D800-U+DFFF). Tested with: - Emoji: '👋 🔥' - Surrogates: '\ud800' - International text: 中文, العربية, Тест Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6404af2 to
9f1c37b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add Unicode sanitization for cloud embedders
Problem
Cloud embedding APIs (VoyageAI, OpenAI, etc.) reject texts containing Unicode surrogates and certain emoji characters, causing
UnicodeEncodeErrorin production.Error Example
Root Cause
Solution
Added
_sanitize_unicode()function that:surrogatepasserror handlingImplementation
Testing
Tested with:
Impact
Checklist
Related Issues
Fixes production issue with VoyageAI and OpenAI embedders rejecting texts with emoji/surrogates.