Allow macros that shadow mldsa-native functions#305
Open
bensze01 wants to merge 1 commit into
Open
Conversation
check_names.py normally requires uppercase macro names. Make an exception for helper macros that shadow the functions names used by mldsa-native. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
added
enhancement
7 tasks
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
Ok in principle, but can we make the exception more specific?
| # platforms that claim single-uppercase-letter names for themselves). | ||
| INTERNAL_MACRO_PATTERN = re.compile("^[A-Z][0-9A-Z_]*[A-Z0-9]$") | ||
| # | ||
| # We make an exception for the helper macros that shadow the functions |
Contributor
There was a problem hiding this comment.
I'd prefer to make the exception more specific and do it via to name_pattern_exception. Is there a reason why that wouldn't work?
bjwtaylor
reviewed
May 19, 2026
bjwtaylor
left a comment
bjwtaylor
left a comment
There was a problem hiding this comment.
Looks good except for the issue Gilles pointed out, the commit message also has a grammatical error “functions names” should be “function names”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
check_names.pynormally requires uppercase macro names. Make an exception for helper macros that shadow the functions names used by mldsa-native.PR checklist