fix deadlock (maybe)#35
Merged
Merged
Conversation
nonchris
force-pushed
the
new-test-defiently-not-existing-yet
branch
from
e908b87 to
69e5c98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#25 introduced a kinda reproducible, but rather unexplainable deadlock.
in #31 the issue was fixed/ diagnosed in the logging module.
the fix was adding code that seemingly doesnt fix anything, so it left me confused.
i looked at all changes from #25 again and the only change with a potentially(!) potential reason for deadlocks was the introduction of a seemingly harmless property...
properties are cool, but they introduce some kind of complexity. and maybe we run into some weird edgecase...
so i just reverted this change in this branch....
@MayNiklas ran the tests, that normally reproduced the issue and they passed.
i cant really explain why. but here we are.