Changes from jitsi/jebml #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for Simple Tags
Modifying unit test to add a Simple Tag.
… mkvalidator) in how 'Cues' and 'Tags' are handled. Also, fixing an issue where the wrong file position was being used in the "Meta Seek" headers for the "Cues" section.
…rue for non-key frames and false otherwise.
Pulling change from Matroska-Org master
* Add support for ColourSpace (cherry picked from commit ca5f8cf) * Add support for ColourSpace - ByteBuffer instead of byte[]
* Add support for non-seekable DataWriters. (cherry picked from commit 8d454ec) * Add support for non-seekable DataWriters. Cues and meta seek are not written.
* feat: Sync with matroska v4 spec. * fix: Skips adding some element if no data was provided. * fix: Fix adding all tracks in the cue. We used to add only the track of the current frame when flushing, so it does not guarantee all tracks inclusion. With current approach we will have in a cluster all tracks on their first frame added. * fix: Fixes updating segment size on closing file. * fix: Updates tags entry creation. * feat: Adds duration in segment. * fix: Fixes Date computation.
* Add "target" to gitignore. * fix: Fix case where frames might be added out of order For example, if an entire track is added starting at timecode 0, and then another track is added starting against at timecode 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We started using (a fork of) this project recently and ended up adding some updates and fixes. Is there any interest in merging them back here? If there is, we can open individual PRs for each change (this big PR is just because I couldn't find another way to get in touch).
https://github.com/jitsi/jebml/commits/jitsi/