Potential fix for code scanning alert no. 3: Use of insecure SSL/TLS version #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/MatrixTM/MHDDoS/security/code-scanning/3
The best way to fix the problem is to explicitly restrict the allowed TLS versions on the
SSLContextto TLS 1.2 or higher. This is done by settingctx.minimum_versiontossl.TLSVersion.TLSv1_2immediately after the context is created. You should update the region afterctxis created in start.py (around line 44) to add this statement.Also, to ensure consistency and avoid ambiguity, check that the protocol is set for the single global context used for HTTPS connections. You do not need to modify the way the socket wrapping on line 875 works, only ensure that the context itself is securely configured.
Required change: Add
ctx.minimum_version = ssl.TLSVersion.TLSv1_2after line 46 (where context options are set).Suggested fixes powered by Copilot Autofix. Review carefully before merging.