Skip to content

Conversation

@anth2o
Copy link
Collaborator

@anth2o anth2o commented Jan 9, 2022

This PR adds several:

  • a Dockerfile so that we can easily ship the application
  • change the URL of the requirement to readPTU so that there are no more installation issues such as this one, however this needs to be checked directly by uploading the app on streamlit Cloud. When this PR is merged we can set the original URL in the requirements.txt file
  • Improve Makefile fomatting by using Markdown syntax. You could refer to this documentation for more details

Also @MathiasPnt I couldn't merge could into master because I don't what sould be kept from each branch,but I advise you to do it to prevent the 2 branches to diverge too much.

@MathiasPnt MathiasPnt merged commit cfd3441 into master Jan 9, 2022
@MathiasPnt
Copy link
Owner

Bravo et merci

@MathiasPnt MathiasPnt deleted the add_docker_setup branch January 9, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants