Skip to content

<fix>[vpc]: add mn vip in vpc bootstrap info#3678

Open
zstack-robot-2 wants to merge 1 commit intofeature-5.5.12-vpc-snat-tracefrom
sync/boce.wang/feature-snat-log-final
Open

<fix>[vpc]: add mn vip in vpc bootstrap info#3678
zstack-robot-2 wants to merge 1 commit intofeature-5.5.12-vpc-snat-tracefrom
sync/boce.wang/feature-snat-log-final

Conversation

@zstack-robot-2
Copy link
Copy Markdown
Collaborator

Related: ZSTAC-83962

Change-Id: I6868776c265d3e1b40174d2496b6a5890cf8b182

sync from gitlab !9539

Related: ZSTAC-83962

Change-Id: I6868776c265d3e1b40174d2496b6a5890cf8b182
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: f8de265d-0d87-4263-ba4b-9cf18e142576

📥 Commits

Reviewing files that changed from the base of the PR and between 594581d and 4c54295.

📒 Files selected for processing (2)
  • plugin/applianceVm/src/main/java/org/zstack/appliancevm/ApplianceVmConstant.java
  • plugin/applianceVm/src/main/java/org/zstack/appliancevm/ApplianceVmFacadeImpl.java

概览

在ApplianceVM引导配置流程中新增管理节点虚拟IP参数。向BootstrapParams枚举添加managementNodeVip常量,并在引导信息准备方法中将其映射到Platform.getManagementServerVip()的返回值。

变更

内聚组/文件(s) 摘要
引导参数配置
plugin/applianceVm/src/main/java/org/zstack/appliancevm/ApplianceVmConstant.java, plugin/applianceVm/src/main/java/org/zstack/appliancevm/ApplianceVmFacadeImpl.java
在BootstrapParams枚举新增managementNodeVip常量,并在prepareBootstrapInformation方法中将其关联到管理服务器VIP值。

代码审查工作量估计

🎯 1 (Trivial) | ⏱️ ~5 minutes

诗歌

🐰 跳跃欢欣,枚举绽新芽
VIP参数轻轻添,
引导信息更完善,
管理节点心心相连!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed PR标题遵循required格式,清晰描述了主要变更内容(在VPC bootstrap信息中添加管理节点VIP),长度为44字符未超过限制。
Description check ✅ Passed PR描述与变更集相关,包含JIRA链接和change-id信息,说明了来源。

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/boce.wang/feature-snat-log-final

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants