forked from zstackio/zstack
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(sdnController): validate L2 network detach before SDN controller delete #3346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZStack-Robot
wants to merge
26
commits into
5.5.6
Choose a base branch
from
sync/ye.zou/fix/ZSTAC-80186
base: 5.5.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6b4521b
<fix>[vm]: use max of virtual and actual size for root disk when no d…
AlanJager 3b5bda3
<fix>[zbs]: enable tryNext and 30s timeout for getActiveClients MDS call
AlanJager 80df074
<fix>[vm]: add Destroying->Stopped state transition
AlanJager a84a36e
<fix>[ceph]: apply over-provisioning ratio when releasing snapshot ca…
AlanJager f19223a
<fix>[loadBalancer]: block SLB deletion during grayscale upgrade
AlanJager 24d4f3b
<fix>[i18n]: improve snapshot error message for unattached volume
AlanJager f563992
<fix>[compute]: add null check for VmNicVO in afterDelIpAddress and a…
AlanJager 6545350
<fix>[network]: filter reserved IPs from GetFreeIp API results
AlanJager 76490a5
Merge branch 'fix/ZSTAC-80620' into '5.5.12'
461e8a2
Merge branch 'fix/ZSTAC-82153' into '5.5.12'
32e1e94
Merge branch 'fix/ZSTAC-80595' into '5.5.12'
addec8c
Merge branch 'fix/ZSTAC-74683' into '5.5.12'
26b8b1a
<fix>[mn]: synchronize hash ring operations to prevent dual-MN task s…
AlanJager be53c72
Merge branch 'fix/ZSTAC-81182' into '5.5.12'
e1dee9f
Merge branch 'fix/ZSTAC-79709' into '5.5.12'
3bd062b
Merge branch 'fix/ZSTAC-81741' into '5.5.12'
aaeaf39
<fix>[storage]: desensitize mdsUrls in ExternalPrimaryStorageInventory
AlanJager f41558d
<fix>[volumebackup]: add backup cancel timeout error code
AlanJager 673be94
Merge branch 'fix/ZSTAC-77711' into '5.5.12'
7f53f5a
<fix>[thread]: guard Context.current() with telemetry check
PandaWuu 72ce6ef
Merge branch 'bugfix/ZSTAC-82275' into '5.5.12'
PandaWuu 34bceb1
Merge branch 'fix/ZSTAC-78989' into '5.5.12'
3e02188
Merge branch 'fix/ZSTAC-82195' into '5.5.12'
799a84f
Merge branch 'fix/ZSTAC-80664' into '5.5.12'
1986d32
<fix>[sdnController]: validate L2 network detach before SDN controlle…
AlanJager 675b764
<fix>[sdnController]: delete pools before SDN controller in test cleanup
AlanJager File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: MatheMatrix/zstack
Length of output: 7322
🏁 Script executed:
Repository: MatheMatrix/zstack
Length of output: 229
🏁 Script executed:
Repository: MatheMatrix/zstack
Length of output: 11656
🏁 Script executed:
Repository: MatheMatrix/zstack
Length of output: 1054
🏁 Script executed:
Repository: MatheMatrix/zstack
Length of output: 2180
🏁 Script executed:
Repository: MatheMatrix/zstack
Length of output: 44
🏁 Script executed:
Repository: MatheMatrix/zstack
Length of output: 3072
mdsInfos数据结构与处理逻辑不兼容。当前代码在第77行对
mdsInfos调用desensitizeUrlList方法,但存在数据结构错配:mdsUrls是List<String>(URL字符串),适合该方法处理mdsInfos经过JSONObjectUtil.toObject(..., LinkedHashMap.class)反序列化后,实际为List<LinkedHashMap>(复杂对象)String.valueOf(LinkedHashMap)生成的字符串格式为{key=value}形式,不符合 URL 格式desensitizeUrl方法期望处理scheme://user:pass@host格式的 URL,无法正确处理 Map 对象的字符串表示结果是
mdsInfos列表中的对象会被错误地序列化为字符串,破坏原有数据结构和敏感信息的脱敏。建议为mdsInfos设计专门的处理逻辑来脱敏其中的username、password等敏感字段。🤖 Prompt for AI Agents