Skip to content

Fixed negative intersection calculation #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaharzuler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed negative intersection calculation #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
975bc52
Updated intersect_area() calculation - fixed negative IoU values
shaharzuler Jan 16, 2021
218c99f
Merge pull request #1 from shaharzuler/shaharzuler-patch-1
shaharzuler Jan 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions mean_average_precision/utils/bbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ def intersect_area(box_a, box_b):
min_xy = np.maximum(resized_A[:, :, :2], resized_B[:, :, :2])

diff_xy = (max_xy - min_xy)
inter = np.clip(diff_xy, a_min=0, a_max=np.max(diff_xy))
inter = np.maximum(diff_xy, 0)
inter_max = np.max(diff_xy)
if inter_max > 0:
inter = np.minimum(inter_max, inter)

return inter[:, :, 0] * inter[:, :, 1]


Expand All @@ -46,4 +50,4 @@ def jaccard(box_a, box_b):
area_a = area_a[:, np.newaxis]
area_b = area_b[np.newaxis, :]
union = area_a + area_b - inter
return inter / union
return inter / union