adapter: introduce UserWriteResponder for PendingWriteTxn::User#36670
Open
aljoscha wants to merge 1 commit into
Open
adapter: introduce UserWriteResponder for PendingWriteTxn::User#36670aljoscha wants to merge 1 commit into
aljoscha wants to merge 1 commit into
Conversation
Wrap the per-session `PendingTxn` inside `PendingWriteTxn::User` in a new `UserWriteResponder` enum (single `Session(PendingTxn)` variant for now). Construction and pattern-matching sites are updated to thread the value through `UserWriteResponder::Session(...)`; `DeferredWrite` keeps its raw `pending_txn: PendingTxn` because the deferred-op machinery is session-only and doesn't gain by going through the responder. This is preparation: the read-then-write OCC path will need to commit writes whose result is delivered via a oneshot rather than retired through an `ExecuteContext`. Introducing the abstraction with one variant first makes the OCC commit additive (a new `Internal` variant plus the call sites that produce/consume it) instead of also having to rename the field at every existing site. No behavior change. Work towards MaterializeInc/database-issues#6686 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the per-session
PendingTxninsidePendingWriteTxn::Userin a newUserWriteResponderenum (singleSession(PendingTxn)variant for now). Construction and pattern-matching sites are updated to thread the value throughUserWriteResponder::Session(...);DeferredWritekeeps its rawpending_txn: PendingTxnbecause the deferred-op machinery is session-only and doesn't gain by going through the responder.This is preparation: the read-then-write OCC path will need to commit writes whose result is delivered via a oneshot rather than retired through an
ExecuteContext. Introducing the abstraction with one variant first makes the OCC commit additive (a newInternalvariant plus the call sites that produce/consume it) instead of also having to rename the field at every existing site. No behavior change.Work towards https://github.com/MaterializeInc/database-issues/issues/6686