crypto: switch rdkafka from vendored OpenSSL to AWS-LC#35861
Draft
jasonhernandez wants to merge 1 commit intojason/sec-200-fivetran-destination-crypto-tlsfrom
Draft
crypto: switch rdkafka from vendored OpenSSL to AWS-LC#35861jasonhernandez wants to merge 1 commit intojason/sec-200-fivetran-destination-crypto-tlsfrom
jasonhernandez wants to merge 1 commit intojason/sec-200-fivetran-destination-crypto-tlsfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
6bac7ec to
1fd6fde
Compare
b8a7586 to
474920d
Compare
Replace librdkafka's vendored OpenSSL with a pre-built AWS-LC static library for FIPS 140-3 compliance on all Kafka sources and sinks. Changes: - Switch all 7 crates from ssl-vendored to ssl-awslc feature - Point rdkafka/rdkafka-sys at fork branch with ssl-awslc support - Add AWS-LC static library build to CI builder Dockerfile (with ninja) - Add AWS-LC build to macOS clippy CI step (with Go installer) - rdkafka-sys build.rs reads AWS_LC_DIR (default /opt/aws-lc) and passes it to librdkafka's CMake as OPENSSL_ROOT_DIR Part of SEC-237. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
474920d to
6913ede
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch librdkafka's crypto backend from vendored OpenSSL to AWS-LC for FIPS 140-3 compliance. This affects every Kafka source and sink.
Changes
Fork (MaterializeInc/rust-rdkafka, branch
jasonhernandez/ssl-awslc):aws-lc-sysoptional dependency tordkafka-sysssl-awslcfeature that links librdkafka against AWS-LC instead of OpenSSLThis repo:
ssl-vendoredtossl-awslc[patch]to point at the fork branchWhy this works
OPENSSL_NO_ENGINE)OPENSSL_NO_ENGINE, reports as OpenSSL 1.1.1g — correct code pathsNote
The fork branch needs to be merged to
MaterializeInc/rust-rdkafkamain before this PR can land. Currently usingbranch = "jasonhernandez/ssl-awslc".Part of SEC-237.
Test plan
cargo check -p mz-kafka-utilpasses locally🤖 Generated with Claude Code