docs: add licensing check guidance to CLAUDE.md and sync license lists#35856
Draft
jasonhernandez wants to merge 1 commit intomainfrom
Draft
docs: add licensing check guidance to CLAUDE.md and sync license lists#35856jasonhernandez wants to merge 1 commit intomainfrom
jasonhernandez wants to merge 1 commit intomainfrom
Conversation
Add a "Licensing checks" section to CLAUDE.md explaining: - The dual-file license policy (deny.toml + about.toml must stay in sync) - How to handle new licenses, duplicate versions, and banned crates - Which commands to use for verification Also sync the license allow lists: add Unicode-DFS-2016 to deny.toml (was already in about.toml but missing from deny.toml). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deny.toml+about.toml), how to handle new licenses, duplicate versions, and banned cratesUnicode-DFS-2016todeny.toml(was already inabout.tomlbut missing fromdeny.toml— pre-existing drift on main)Context
The
deny.tomlandabout.tomlfiles must be manually kept in sync (noted in comments in both files). They had drifted —about.tomlhadUnicode-DFS-2016butdeny.tomldidn't. This caused no CI failure becausecargo denyandcargo aboutcheck different things, but it's a latent inconsistency.Adding CLAUDE.md guidance ensures AI-assisted dependency changes will check both files.
Test plan
cargo deny check licensespasses🤖 Generated with Claude Code