Skip to content

[cluster] Mark RowRef::from_slice as unsafe#35034

Merged
bkirwi merged 1 commit intoMaterializeInc:mainfrom
bkirwi:more-unsafe
Feb 17, 2026
Merged

[cluster] Mark RowRef::from_slice as unsafe#35034
bkirwi merged 1 commit intoMaterializeInc:mainfrom
bkirwi:more-unsafe

Conversation

@bkirwi
Copy link
Contributor

@bkirwi bkirwi commented Feb 16, 2026

Motivation

Previously-unreported bug. (It was incorrect to mark this function safe, though nobody seems to have been using it unsafely in practice.)

@github-actions
Copy link

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bkirwi bkirwi marked this pull request as ready for review February 17, 2026 18:00
@bkirwi bkirwi requested a review from a team as a code owner February 17, 2026 18:00
@bkirwi bkirwi merged commit cc8a010 into MaterializeInc:main Feb 17, 2026
134 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments