unify timestamping interval into a single system parameter#35027
Open
petrosagg wants to merge 4 commits intoMaterializeInc:mainfrom
Open
unify timestamping interval into a single system parameter#35027petrosagg wants to merge 4 commits intoMaterializeInc:mainfrom
petrosagg wants to merge 4 commits intoMaterializeInc:mainfrom
Conversation
Pre-merge checklist
|
petrosagg
force-pushed
the
timestamp-interval-system-var
branch
from
a020e63 to
3385659
Compare
This PR replaces five dyncfg parameters (`pg_offset_known_interval`, `mysql_offset_known_interval`, `kafka_default_metadata_fetch_interval`, `sql_server_cdc_poll_interval`, `sql_server_offset_known_interval`) and a hardcoded 1s constant with a single `timestamp_interval` system parameter. This parameter controls the timestamping interval of tables and the default timestamping interval of sources. For sources, users can specify a custom timestamping interval as part of the `CREATE SOURCE` statement using the `TIMESTAMP INTERVAL` WITH option. When this parameter is not specified the source is created with the current value of the `timestamp_interval` system parameter. Changing the global `timestamp_interval` parameter won't affect already created sources. To change the timestamp interval of an already created source an `ALTER SOURCE` statement is needed. The value of `timestamp_interval` is validated against `min_timestamp_interval` and `max_timestamp_interval`. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg
force-pushed
the
timestamp-interval-system-var
branch
from
2414c0f to
2ca8b31
Compare
def-
reviewed
Feb 16, 2026
Contributor
def-
left a comment
def-
left a comment
There was a problem hiding this comment.
Nightly triggered: https://buildkite.com/materialize/nightly/builds/15175
I also want to see what happens if you lower it to 10 ms in all of CI, maybe something falls over in an interesting way: https://buildkite.com/materialize/test/builds/115951
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces five dyncfg parameters (
pg_offset_known_interval,mysql_offset_known_interval,kafka_default_metadata_fetch_interval,sql_server_cdc_poll_interval,sql_server_offset_known_interval) and a hardcoded 1s constant with a singletimestamp_intervalsystem parameter.This parameter controls the timestamping interval of tables and the default timestamping interval of sources. For sources, users can specify a custom timestamping interval as part of the
CREATE SOURCEstatement using theTIMESTAMP INTERVALWITH option. When this parameter is not specified the source is created with the current value of thetimestamp_intervalsystem parameter. Changing the globaltimestamp_intervalparameter won't affect already created sources. To change the timestamp interval of an already created source anALTER SOURCEstatement is needed.The value of
timestamp_intervalis validated againstmin_timestamp_intervalandmax_timestamp_interval.part of CLU-25