compute: split index peek literal constraints per worker#35026
Draft
antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
Draft
compute: split index peek literal constraints per worker#35026antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
antiguru wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
Arrangement data is sharded by `row.hashed() % peers`, so for index peeks with literal constraints only one worker holds data for a given key. Route each constraint to the owning worker in the command channel and have workers with no constraints short-circuit with an empty response, avoiding unnecessary trace clones, compaction, and cursor seeks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pre-merge checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
row.hashed() % peers), instead of broadcasting all constraints to all workersKnown limitation: errors in arrangements are not sharded by key, so workers that receive no constraints may miss errors. This PR is for performance exploration only.
Test plan
cargo check -p mz-computecargo clippy -p mz-compute -p mz-compute-clientcargo test -p mz-compute-clientbin/sqllogictest -- test/sqllogictest/transform/literal_constraints.sltbin/sqllogictest -- test/sqllogictest/transform/notice/index_too_wide_for_literal_constraints.sltbin/sqllogictest -- test/sqllogictest/indexes.slt🤖 Generated with Claude Code