Skip to content

controller: Separate instance_client#35010

Merged
ggevay merged 1 commit intoMaterializeInc:mainfrom
ggevay:instance_client-refactoring-1
Feb 16, 2026
Merged

controller: Separate instance_client#35010
ggevay merged 1 commit intoMaterializeInc:mainfrom
ggevay:instance_client-refactoring-1

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented Feb 13, 2026

This is a refactoring related to the frontend peek sequencing, partially addressing the second paragraph of #33713 (comment) + other related discussions with Moritz and Jan.

This PR is purely code movement: it moves the Client from instance.rs into a new file instance_client.rs, and renames it to InstanceClient. (This is used by the frontend peek sequencing directly, bypassing the ComputeController, because we don't want the Coordinator to be a bottleneck for fast-path peeks.)

Part 1 of 3 from the original #34839. (Based on @teskje's comment there, we probably do want this code movement, right? What do you think, @antiguru?)

@ggevay ggevay added the A-controller Area: controllers label Feb 13, 2026
@github-actions
Copy link

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@ggevay ggevay marked this pull request as ready for review February 13, 2026 22:01
@ggevay ggevay requested review from a team as code owners February 13, 2026 22:01
@ggevay ggevay requested review from antiguru and ohbadiah February 13, 2026 22:01
Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nits.

@ggevay ggevay force-pushed the instance_client-refactoring-1 branch from 11b16a0 to 4a85e8b Compare February 16, 2026 20:19
@ggevay
Copy link
Contributor Author

ggevay commented Feb 16, 2026

Thank you, all done.

(Will wait for @antiguru's review before merging.)

@ggevay ggevay force-pushed the instance_client-refactoring-1 branch from 4a85e8b to 46fe140 Compare February 16, 2026 20:21
Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks

@ggevay ggevay enabled auto-merge (squash) February 16, 2026 20:23
@ggevay ggevay merged commit 3f85ba8 into MaterializeInc:main Feb 16, 2026
133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-controller Area: controllers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants