adapter: Disallow unmaterializable funcs in AS OF queries#34998
Open
ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
Open
adapter: Disallow unmaterializable funcs in AS OF queries#34998ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
Pre-merge checklist
|
660e9d7 to
08e276c
Compare
08e276c to
5853c36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/MaterializeInc/database-issues/issues/10004 by simply disallowing unmaterializable functions in AS OF queries.
Hopefully this is not a thing that users do today, but the PR adds a break glass feature flag that we can flip if it turns out that somebody wants to do this. We can remove the flag after one week in prod.
I think it's good to do this change rather sooner than later, before somebody actually starts doing such queries, at which point it would be more of a hassle to disallow it.
(Doesn't affect
SUBSCRIBE; no unmaterializable function calls there anyways.)