Skip to content

ci: add line length lint step using nightly cargo fmt#34997

Merged
antiguru merged 3 commits intoMaterializeInc:mainfrom
antiguru:cargo_fmt
Feb 16, 2026
Merged

ci: add line length lint step using nightly cargo fmt#34997
antiguru merged 3 commits intoMaterializeInc:mainfrom
antiguru:cargo_fmt

Conversation

@antiguru
Copy link
Member

@antiguru antiguru commented Feb 12, 2026

rustfmt refuses to format files that have too long lines, which results in some files silently skipping formatting. Add a new CI lint step that runs cargo +nightly fmt -- --check --config error_on_line_overflow=true to catch overly long lines in Rust source files. This check is only available on nightly Rust.

@antiguru antiguru requested a review from a team as a code owner February 12, 2026 21:43
@github-actions
Copy link

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@antiguru antiguru force-pushed the cargo_fmt branch 3 times, most recently from 06e2744 to 878f9e4 Compare February 12, 2026 22:06
@def- def- requested review from a team as code owners February 16, 2026 14:13
@def- def- requested review from aljoscha and def- February 16, 2026 14:13
@antiguru antiguru enabled auto-merge (squash) February 16, 2026 14:51
@def- def- force-pushed the cargo_fmt branch 2 times, most recently from 8b7bbd2 to c180dee Compare February 16, 2026 23:12
@antiguru antiguru merged commit 4267863 into MaterializeInc:main Feb 16, 2026
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants