Skip to content

Conversation

@vmarcos
Copy link
Contributor

@vmarcos vmarcos commented Jan 9, 2023

This PR retrospectively migrates and refines an internal document into a design document for recent changes to monotonic top-k rendering introduce in PR #16813.

Advances MaterializeInc/database-issues#4838.

Motivation

  • This PR adds documentation.

Tips for reviewer

Note that only minimal edits were performed to put the internal document into our template for design documents. Since the original document was quite extensive, I hope this is OK; otherwise, please let me know!

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a
    companion cloud PR to account for those changes that is tagged with
    the release-blocker label (example).
  • This PR includes the following user-facing behavior changes: N/A

@vmarcos vmarcos requested review from antiguru and umanwizard January 9, 2023 11:34
@vmarcos vmarcos marked this pull request as ready for review January 9, 2023 11:38
Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vmarcos vmarcos merged commit 85cbc50 into MaterializeInc:main Jan 11, 2023
@vmarcos vmarcos deleted the monotonic_topk_design_doc branch January 11, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants