Feature/flag to stop needle at max for percentage above 100#40
Open
eirikaho wants to merge 9 commits into
Open
Feature/flag to stop needle at max for percentage above 100#40eirikaho wants to merge 9 commits into
eirikaho wants to merge 9 commits into
Conversation
added 2 commits
February 25, 2020 08:46
Owner
|
There are some merge conflicts. Could you merge your local branch with the latest master and fix them? |
added 3 commits
April 15, 2020 08:37
…p-needle-at-max-for-percentage-above-100 # Conflicts: # package-lock.json # src/lib/GaugeChart/index.js
Author
done ✔️ |
Owner
|
@eirikaho It looks great. I was just thinking, maybe the stop at 100% prop should be set default to true? For me it seems like the most logical behavior for the chart. Or it could even be something that is not a optional thing. What do you think? |
Author
|
@Martin36 I agree, it could definitely be the default behaviour and not even an optional prop. Should I update the PR with that change? |
Owner
|
@eirikaho Sorry for the late reply, but you can do that |
|
I solved this problem in the following way. const newPercent = Math.min(percent, 1);
<GaugeChart
percent={newPercent}
formatTextValue={value => (percent > 1 ? `${(percent * 100).toFixed(0)}%` : `${value}%`)}
/>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added 'stopNeedleAtMax' prop to flag that the needle should stop just above max for percentages above 1.0.
stopNeedleAtMax={true}

stopNeedleAtMax={false}
