Skip to content

Added option to dynamically generate gecko driver mappings #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeeshanyshaikh wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added option to dynamically generate gecko driver mappings #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ac4c2e
Added option to dynamically generate gecko driver mappings
Oct 20, 2022
61f48dd
updates the sequence
Oct 20, 2022
717fa41
Converted browser version to integer
Oct 20, 2022
881b3bc
rectified a minor glitch in version to add "v" before all driver vers…
Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/webdrivermanager/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,3 +383,20 @@ def download_and_install(self, version="latest", show_progress_bar=True):
except Exception as e:
LOGGER.warning(f"Unable to change permissions of {dest_file}.\n{e}")
return (src_file, dest_file)


def _get_gecko_mappings():
URL = 'https://firefox-source-docs.mozilla.org/testing/geckodriver/Support.html'
page = requests.get( URL )
soup = BeautifulSoup( page.content , 'lxml')

table = soup.find("div", {"id": "supported-platforms"}).find("table")
rows = table.find_all('tr')
version_map = []
for row in rows:
cols=row.find_all('td')
if len(cols) > 0:
cols=[x.text.strip() for x in cols ]
version_map.append((int(cols[2].split(" ")[0]), "v"+cols[0]))

return version_map
3 changes: 2 additions & 1 deletion src/webdrivermanager/gecko.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ def get_compatible_version(self):
# Map browser version to webdriver version
# https://firefox-source-docs.mozilla.org/testing/geckodriver/Support.html
browser_version = self._get_browser_version()
version_map = [(60, "v0.29.0"), (57, "v0.25.0"), (55, "v0.20.1"), (53, "v0.18.0"), (52, "v0.17.0")]
# version_map = [(60, "v0.29.0"), (57, "v0.25.0"), (55, "v0.20.1"), (53, "v0.18.0"), (52, "v0.17.0")]
version_map = self._get_gecko_mappings()

for browser_minimum, driver_version in version_map:
if browser_version >= browser_minimum:
Expand Down