TICKET-583: Include due date in LTI gradebook sync by Naragod · Pull Request #7872 · MarkUsProject/Markus

Naragod · 2026-03-20T21:01:33Z

Proposed Changes 🐛 Bug fix

When creating or updating a gradebook item via LTI, MarkUs sends a line item payload to Canvas containing the assignment label, resource ID, and maximum score. The dueAt field supported by the LTI Assignment and Grade Services (AGS) specification was missing from this payload, and the due date set in MarkUs remained absent on the corresponding Canvas assignment. The fix adds dueAt as an ISO 8601 timestamp to the payload when the assessment has a due date, ensuring it is synced during both line item creation and updates.

Screenshots of your changes (if applicable)

Screen.Recording.2026-05-07.at.12.29.06.PM.mov

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)	X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

I have performed a self-review of my changes.
- Check that all changed files included in this pull request are intentional changes.
- Check that all changes are relevant to the purpose of this pull request, as described above.
I have added tests for my changes, if applicable.
- This is required for all bug fixes and new features.
I have updated the project documentation, if applicable.
- This is required for new features.
If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

I have updated the project Changelog (this is required for all changes).
I have verified that the pre-commit.ci checks have passed.
I have verified that the CI tests have passed.
I have reviewed the test coverage changes reported by Coveralls.
I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

coveralls · 2026-03-20T21:27:21Z

Coverage Report for CI Build 25508597171

Coverage increased (+0.003%) to 91.729%

Details

Coverage increased (+0.003%) from the base build.
Patch coverage: 67 of 67 lines across 4 files are fully covered (100%).
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	48751
Covered Lines:	45463
Line Coverage:	93.26%
Relevant Branches:	1870
Covered Branches:	971
Branch Coverage:	51.93%
Branches in Coverage %:	Yes
Coverage Strength:	130.21 hits per line

💛 - Coveralls

donny-wong

Thanks for this. However, when I tested it locally, the due date was still not syncing to Canvas. Are you able to sync on your end?

Naragod · 2026-04-21T02:56:22Z

Thanks for this. However, when I tested it locally, the due date was still not syncing to Canvas. Are you able to sync on your end?

Hi Donny, I have updated PR and posted a screenshot.

donny-wong · 2026-04-27T19:22:13Z

Thanks for this. However, when I tested it locally, the due date was still not syncing to Canvas. Are you able to sync on your end?

Hi Donny, I have updated PR and posted a screenshot.

Thanks @Naragod , strange, I am still unable to sync it. Maybe you can show me tomorrow.

Thanks for this. However, when I tested it locally, the due date was still not syncing to Canvas. Are you able to sync on your end?

Hi Donny, I have updated PR and posted a screenshot.

Hi @Naragod , strange, I still cannot sync it on my end. Would you have some idea why that would be?

david-yz-liu · 2026-05-09T00:48:14Z

    self.completed_result_marks.count(&:zero?)
  end

+  # Re-pushes line item metadata to any LMS that already has this assessment linked,


In general please make callback methods private.

david-yz-liu · 2026-05-09T00:49:10Z

+    it 'sends JSON body with correct LTI AGS Content-Type' do
+      allow(lti_deployment).to receive(:send_lti_request!) do |req, *|
+        expect(req.content_type).to eq('application/vnd.ims.lis.v2.lineitem+json')
+        body = JSON.parse(req.body)


I'm not sure about the interaction with the content type here, but please try using req.parsed_body instead (which should do the JSON parsing for you); we do this in several other tests.

david-yz-liu · 2026-05-09T00:49:50Z

 - Added term-based suffixes to course names created via LTI to ensure uniqueness across academic years (#7881)

 ### 🐛 Bug fixes
+- Sync due date when creating or updating LTI gradebook line items, and re-sync automatically when an assessment is edited (#7756)


Please correct the PR number and move this to "enhancements"

Naragod marked this pull request as draft March 20, 2026 21:05

Naragod force-pushed the TICKET-583_lti_sync_due_date branch from 5ac1ae4 to 100ca98 Compare March 23, 2026 14:17

Naragod marked this pull request as ready for review March 23, 2026 14:17

Naragod requested a review from donny-wong March 23, 2026 14:18

Naragod force-pushed the TICKET-583_lti_sync_due_date branch 2 times, most recently from 78c0eda to ca824e6 Compare March 24, 2026 20:23

donny-wong reviewed Mar 25, 2026

View reviewed changes

Naragod force-pushed the TICKET-583_lti_sync_due_date branch from ca824e6 to c29ef77 Compare March 25, 2026 18:06

Naragod force-pushed the TICKET-583_lti_sync_due_date branch from c29ef77 to 33fe566 Compare April 21, 2026 01:52

Naragod requested a review from donny-wong April 21, 2026 02:56

Naragod force-pushed the TICKET-583_lti_sync_due_date branch from 33fe566 to 41cbd44 Compare April 21, 2026 16:41

Naragod linked an issue Apr 23, 2026 that may be closed by this pull request

LTI - create new gradebook items does not sync due date #7756

Open

Naragod added 6 commits May 6, 2026 15:15

TICKET-583: Include due date in LTI gradebook sync

164d8f2

TICKET-583: Fix LTI line item sync to use JSON with correct field name

0516a39

TICKET-583: Add tests for LTI line item JSON payload and endDateTime

9cc27da

TICKET-583: Auto-resync LTI line items on assessment update

b413f37

TICKET-583: Add specs for assessment LTI auto-resync

8f07a3a

TICKET-583: Add changelog entry for LTI due date sync

1117257

Naragod force-pushed the TICKET-583_lti_sync_due_date branch from 41cbd44 to 1117257 Compare May 7, 2026 16:27

donny-wong approved these changes May 8, 2026

View reviewed changes

donny-wong requested a review from david-yz-liu May 8, 2026 03:30

david-yz-liu reviewed May 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TICKET-583: Include due date in LTI gradebook sync#7872

TICKET-583: Include due date in LTI gradebook sync#7872
Naragod wants to merge 6 commits intomasterfrom
TICKET-583_lti_sync_due_date

Naragod commented Mar 20, 2026 •

edited

Loading

Uh oh!

coveralls commented Mar 20, 2026 •

edited

Loading

Uh oh!

donny-wong left a comment

Uh oh!

Naragod commented Apr 21, 2026

Uh oh!

donny-wong commented Apr 27, 2026

Uh oh!

david-yz-liu May 9, 2026

Uh oh!

david-yz-liu May 9, 2026

Uh oh!

david-yz-liu May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Naragod commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes 🐛 Bug fix

Type of Change

Checklist

Questions and Comments

Uh oh!

coveralls commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 25508597171

Coverage increased (+0.003%) to 91.729%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

donny-wong left a comment

Choose a reason for hiding this comment

Uh oh!

Naragod commented Apr 21, 2026

Uh oh!

donny-wong commented Apr 27, 2026

Uh oh!

david-yz-liu May 9, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu May 9, 2026

Choose a reason for hiding this comment

Uh oh!

david-yz-liu May 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Naragod commented Mar 20, 2026 •

edited

Loading

coveralls commented Mar 20, 2026 •

edited

Loading