Skip to content

Thinner close button stroke and deduplicate shared resources#47

Merged
cyanzhong merged 3 commits intomainfrom
copilot/make-close-button-stroke-thinner
Mar 19, 2026
Merged

Thinner close button stroke and deduplicate shared resources#47
cyanzhong merged 3 commits intomainfrom
copilot/make-close-button-stroke-thinner

Conversation

Copy link
Contributor

Copilot AI commented Mar 18, 2026

Reduce close button SVG stroke-width from 1.5 to 1.2 for a lighter visual weight, and extract duplicated resources into shared constants in src/const.ts.

  • src/const.ts — new shared closeSvg and systemFont constants
  • src/tooltip.ts — use shared constants instead of inline duplicates
  • src/panel.ts — use shared constants instead of inline duplicates

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits March 18, 2026 07:19
Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
@cyanzhong
Copy link
Contributor

@copilot Why you are not reusing resources here?

Can you do a full scan of the codebase to find out wasted duplicates?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the visual weight of the “close” (X) icon used on suggestion cards to better match the intended UI styling across both the tooltip card and the sidebar problems panel.

Changes:

  • Reduced the close button SVG stroke-width from 1.5 to 1.2 in the tooltip suggestion card.
  • Reduced the close button SVG stroke-width from 1.5 to 1.2 in the sidebar pane header close button.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/tooltip.ts Updates the tooltip card close-button SVG stroke width to 1.2.
src/panel.ts Updates the sidebar pane close-button SVG stroke width to 1.2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 19, 2026

@copilot Why you are not reusing resources here?

Can you do a full scan of the codebase to find out wasted duplicates?

Extracted the duplicated close button SVG and system font-family stack into shared constants (closeSvg and systemFont) in src/const.ts. Both tooltip.ts and panel.ts now import from there instead of inlining. Addressed in f59d045.

Copilot AI changed the title Thinner stroke width on suggestion card close button Thinner close button stroke and deduplicate shared resources Mar 19, 2026
Copilot AI requested a review from cyanzhong March 19, 2026 11:43
@cyanzhong cyanzhong requested a review from Copilot March 19, 2026 11:54
@cyanzhong cyanzhong marked this pull request as ready for review March 19, 2026 11:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines UI consistency by lightening the close (“X”) icon stroke and centralizing repeated UI resources into src/const.ts, reducing duplication across the tooltip and sidebar panel components.

Changes:

  • Reduced the close button SVG stroke-width from 1.5 to 1.2.
  • Added shared closeSvg and systemFont constants in src/const.ts.
  • Updated tooltip and panel implementations to reference these shared constants instead of inline values.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/const.ts Introduces shared closeSvg and systemFont constants (and keeps repoUrl).
src/tooltip.ts Uses systemFont in tooltip CSS and closeSvg for the close button markup.
src/panel.ts Uses systemFont in pane CSS and closeSvg for the pane close button markup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@cyanzhong cyanzhong merged commit cc29d01 into main Mar 19, 2026
6 checks passed
@cyanzhong cyanzhong deleted the copilot/make-close-button-stroke-thinner branch March 19, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants