bug fixed#101
Conversation
MariaMelnik
left a comment
MariaMelnik
left a comment
There was a problem hiding this comment.
Hi!
Thank for you impact and PR.
I made few comments. Please, check it.
| @@ -0,0 +1 @@ | |||
| C:/Users/dhruv/fvm/versions/2.8.0 No newline at end of file | |||
There was a problem hiding this comment.
this file should not be added to repo. It is your local settings.
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
this file should not be added to repo. It is your local settings.
| @@ -0,0 +1,13 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
this file should not be added to repo. It is your local settings.
| url: "https://pub.dartlang.org" | ||
| source: hosted | ||
| version: "1.16.0" | ||
| version: "1.15.0" |
There was a problem hiding this comment.
Why it is necessary to decrease package version?
Seems like you committed your local saved versions.
| padding: widget.datePickerLayoutSettings.contentPadding, | ||
| child: _buildMonthNavigationRow()), | ||
| ), | ||
| SizedBox( height: 40, width: double.infinity,), |
There was a problem hiding this comment.
Why height is 40?
I assume it should not be hardcoded.
Also if we made new version with such changes all previous users will get this padding. Which is not good.
Seems like solution should not involve breaking changes.
| url: "https://pub.dartlang.org" | ||
| source: hosted | ||
| version: "2.8.1" | ||
| version: "2.8.2" |
There was a problem hiding this comment.
Why it is necessary to change package versions here?
Seems like you committed your local saved versions.
2 participants
The following required space between month and date picker is arranged