MDEV-39405: store all the plugin-engines optimizer costs#5014
MDEV-39405: store all the plugin-engines optimizer costs#5014bsrikanth-mariadb wants to merge 1 commit into
Conversation
bsrikanth-mariadb
force-pushed
the
13.0-MDEV-39405-store-all-engines-opt-costs
branch
from
f94bc59 to
ad93751
Compare
bsrikanth-mariadb
force-pushed
the
13.0-MDEV-39405-store-all-engines-opt-costs
branch
from
ad93751 to
95d3c20
Compare
Please split this into a separate commit. We;ll need this as we will need to do a rebase and put all |
| plugin_foreach_with_mask(thd, store_engine_costs_callback, | ||
| MYSQL_STORAGE_ENGINE_PLUGIN, PLUGIN_IS_READY, | ||
| &sql_script); | ||
| store_optimizer_costs("heap", &heap_optimizer_costs, sql_script); |
There was a problem hiding this comment.
Why is this needed? Shouldn't we have encountered HEAP when enumerating the storage engine plugins? If not, please add a comment about this, preferably explaining why.
|
A general comment, something to consider: |
bsrikanth-mariadb
force-pushed
the
13.0-MDEV-39405-store-all-engines-opt-costs
branch
2 times, most recently
from
ae4619c to
df5872f
Compare
store all the plugin-engines optimizer costs into the context, so that the replay server uses the same engine costs while computing the query cost
bsrikanth-mariadb
force-pushed
the
13.0-MDEV-39405-store-all-engines-opt-costs
branch
from
df5872f to
646e2a2
Compare
sure, reverted. |
2 participants
store all the plugin-engines optimizer costs into the context, so that the replay server uses the same engine costs while computing the query cost