MDEV-39173 Replace sprintf with snprintf#4869
Open
Pochatkin wants to merge 1 commit intoMariaDB:mainfrom
Open
Conversation
…f with snprintf Remove the unscoped #pragma GCC diagnostic ignored "-Wdeprecated-declarations" from include/violite.h. The pragma was originally added to suppress OpenSSL deprecation warnings on macOS, but is no longer needed as modern macOS builds use bundled WolfSSL or external OpenSSL without deprecated declarations. The pragma also silently suppressed ~100 "sprintf is deprecated" warnings on macOS. Replace all sprintf/vsprintf calls with snprintf/vsnprintf across the codebase (118 files), excluding vendored third-party code (readline, wolfssl, wsrep-lib, libmariadb, groonga, zlib).
|
|
Author
|
@gkodinov Could you please take a look as ticket reporter? |
gkodinov
added
the
External Contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.mariadb.org/browse/MDEV-39173
Remove the unscoped #pragma GCC diagnostic ignored "-Wdeprecated-declarations" from include/violite.h. The pragma was originally added to suppress OpenSSL deprecation warnings on macOS, but is no longer needed as modern macOS builds use bundled WolfSSL or external OpenSSL without deprecated declarations.
The pragma also silently suppressed ~100 "sprintf is deprecated" warnings on macOS. Replace all sprintf/vsprintf calls with snprintf/vsnprintf across the codebase (118 files), excluding vendored third-party code (readline, wolfssl, wsrep-lib, libmariadb, groonga, zlib).