Fix ER_OUTOFMEMORY format to use %zu and size_t (MDEV-39138)#4840
Open
Harsh8084 wants to merge 1 commit intoMariaDB:mainfrom
Open
Fix ER_OUTOFMEMORY format to use %zu and size_t (MDEV-39138)#4840Harsh8084 wants to merge 1 commit intoMariaDB:mainfrom
Harsh8084 wants to merge 1 commit intoMariaDB:mainfrom
Conversation
- Replace incorrect %d with %zu for size_t - Update all callers to pass size_t correctly - Update errmsg-utf8.txt - Adjust test results accordingly
32125cf to
1c6e640
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the error message format and all related call sites to use %zu (size_t format) and size_t arguments, ensuring proper handling of large memory values without overflow risk.
Changes Made
Error Message Format
Changed ER_OUTOFMEMORY format from %d to %zu across all language variants.
Fixed a malformed Georgian translation line (missing closing quote).
Source Code Updates
Removed (int) casts and ensured size_t arguments in my_error(ER_OUTOFMEMORY, ...) calls.
Files: handler.cc, item_jsonfunc.cc, item_strfunc.cc, session_tracker.cc, set_var.cc.