Implementation of proposed Typeadapter concept from issue #832#835
Draft
DocSvartz wants to merge 7 commits intoMapsterMapper:developmentfrom
Draft
Implementation of proposed Typeadapter concept from issue #832#835DocSvartz wants to merge 7 commits intoMapsterMapper:developmentfrom
DocSvartz wants to merge 7 commits intoMapsterMapper:developmentfrom
Conversation
Contributor
Author
Yes, but in fact in Mapster it works wit it as a mutable object. |
DocSvartz
commented
Dec 14, 2025
Comment on lines
+37
to
+73
| /// <summary> | ||
| /// Adapt the source object to an existing destination object. | ||
| /// </summary> | ||
| /// <param name="source">Source object to adapt.</param> | ||
| /// <param name="destination">Destination object to populate.</param> | ||
| /// <param name="sourceType">The type of the source object.</param> | ||
| /// <param name="destinationType">The type of the destination object.</param> | ||
| /// <returns>Adapted destination type.</returns> | ||
| public static object? Adapt(this object source, object destination, Type sourceType, Type destinationType) | ||
| { | ||
| return Adapt(source, destination, sourceType, destinationType, TypeAdapterConfig.GlobalSettings); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Adapt the source object to an existing destination object. | ||
| /// </summary> | ||
| /// <param name="source">Source object to adapt.</param> | ||
| /// <param name="destination">Destination object to populate.</param> | ||
| /// <param name="sourceType">The type of the source object.</param> | ||
| /// <param name="destinationType">The type of the destination object.</param> | ||
| /// <param name="config">Configuration</param> | ||
| /// <returns>Adapted destination type.</returns> | ||
| public static object? Adapt(this object source, object destination, Type sourceType, Type destinationType, TypeAdapterConfig config) | ||
| { | ||
| var del = config.GetMapToTargetFunction(sourceType, destinationType); | ||
| if (sourceType.GetTypeInfo().IsVisible && destinationType.GetTypeInfo().IsVisible) | ||
| { | ||
| dynamic fn = del; | ||
| return fn((dynamic)source, (dynamic)destination); | ||
| } | ||
| else | ||
| { | ||
| //NOTE: if type is non-public, we cannot use dynamic | ||
| //DynamicInvoke is slow, but works with non-public | ||
| return del.DynamicInvoke(source, destination); | ||
| } | ||
| } |
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
I don't remember exactly if this is the case here.
But in fact, generic and non-generic adapters behave differently. 😂
Contributor
Author
There's another problem. There are settings that make any type seem "immutable". .ConstructUsing() Maybe: |
Collaborator
|
Hey @DocSvartz, It would be way easier to follow your PR and give you better Feedback when needed, if you would have included some more information 😅 **GitHub Issue:** closes #
<!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue, unless the change is documentation related. -->
## PR Type:
<!--
Copy the labels that apply to this PR and paste them above:
- 🐞 Bugfix
- ✨ Feature
- 🎨 Code style update (formatting)
- 🔄 Refactoring (no functional changes, no api changes)
- 🏗️ Build or CI related changes
- 📚 Documentation content changes
- 🤖 Project automation
- 💬 Other... (Please describe)
-->
## What is the current behavior? 🤔
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
## What is the new behavior? 🚀
<!-- Please describe the new behavior after your modifications. -->
## PR Checklist ✅
Please check if your PR fulfills the following requirements:
- [ ] 📝 Commits must be following the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/#summary) specification.
- [ ] 🧪 Added [Runtime tests, UI tests, or a manual test sample](https://github.com/**/blob/master/docs/articles/contributing/*.md) for the changes have been added (for bug fixes / features) (if applicable)
- [ ] 📚 Docs have been added/updated which fit [documentation template](https://github.com/**/blob/master/docs/.feature-template.md) (for bug fixes / features)
- [ ] 🖼️ Validated PR `Screenshots Compare Test Run` results.
- [ ] ❗ Contains **NO** breaking changes
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below.
Please note that breaking changes are likely to be rejected -->
## Other information ℹ️
<!-- Please provide any additional information if necessary --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need Help :