Fix Race Condition between Configuration and Adapt()#827
Draft
DocSvartz wants to merge 9 commits intoMapsterMapper:developmentfrom
Draft
Fix Race Condition between Configuration and Adapt()#827DocSvartz wants to merge 9 commits intoMapsterMapper:developmentfrom
DocSvartz wants to merge 9 commits intoMapsterMapper:developmentfrom
Conversation
- drop IsConcurrencyEnvironment - all Concurrencymod property to internal
Contributor
Author
Contributor
Author
|
This problem can perhaps be partially solved using Freezing config (without throwing exceptions when changing). However, this needs to be tested with at least 1 million iterations. But maybe I'm not quite understanding the real world use case for this. The only real use case I see is when different adapt configurations are set in different threads. |
This was referenced Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on these tests and #86, #138
Depending on the speed and order of execution (configuration and Adapt()), one of the following situations can occur:
Additional problem:
The current configuration design does not provide information about configuration completion.
add This PR
TypeAdapterConfig.GlobalSettings.ScanConcurrency(Assembly.GetExecutingAssembly());