Skip to content

feat(sync): code review(MAPCO-10530) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RonIsraeli123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(sync): code review(MAPCO-10530) #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/externalClients/layersClient/geometryParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export function geographyToGeoJSON(geography: RawGeography): Geometry {
return lineString(coords.map(toPosition)).geometry as LineString;

case 'POLYGON':
case 'AREA':
if (coords.length < 4) {
throw new Error(`Polygon requires >=4 coordinates (closed ring), got ${coords.length}`);
}
Expand Down
21 changes: 21 additions & 0 deletions tests/unit/externalClients/geometryParser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,27 @@ describe('geographyToGeoJSON', () => {
];
expect(() => geographyToGeoJSON(geo('POLYGON', ring))).toThrow(/Polygon requires >=4/);
});

it('accepts AREA alias as Polygon', () => {
const ring = [
{ latitude: 0, longitude: 0 },
{ latitude: 0, longitude: 1 },
{ latitude: 1, longitude: 1 },
{ latitude: 0, longitude: 0 },
];
const result = geographyToGeoJSON(geo('AREA', ring));
expect(result).toEqual({
type: 'Polygon',
coordinates: [
[
[0, 0],
[1, 0],
[1, 1],
[0, 0],
],
],
});
});
});

describe('error cases', () => {
Expand Down
Loading