feat: tiles deletion creation (MAPCO-5735)#95
Merged
Conversation
…gurations Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…ion in task building Co-authored-by: Copilot <copilot@github.com>
…e for downloading reports Co-authored-by: Copilot <copilot@github.com>
… refactor related interfaces and task parameters Co-authored-by: Copilot <copilot@github.com>
…efining deletion task creation Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…and deletion task manager Co-authored-by: Copilot <copilot@github.com>
…URL handling - Removed S3Service dependency from TileDeletionTaskManager and updated report handling to use a URL instead of a path. - Modified readConflictFeatures function to download ZIP reports from a URL and extract shapefiles. - Enhanced logging messages for clarity in TileMergeTaskManager. - Cleaned up FSService constructor and type annotations for better readability. Co-authored-by: Copilot <copilot@github.com>
…les-deletion-skeleton
CL-SHLOMIKONCHA
changed the title
CL-SHLOMIKONCHA
requested changes
May 11, 2026
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…whitespace in report functions
…skManager to use it Co-authored-by: Copilot <copilot@github.com>
…eation. Co-authored-by: Copilot <copilot@github.com>
…andling in deletion task creation Co-authored-by: Copilot <copilot@github.com>
…processing in FSService Co-authored-by: Copilot <copilot@github.com>
- Added "@types/node" dependency to package.json for better type support. - Refactored UpdateJobHandler to improve code readability. - Modified FSService constructor for consistency and updated file hashing logic to use 'data' event. - Enhanced unit tests for updateJobHandler to include validation task handling. - Updated jobManagerMocks to include findTasks mock for better test coverage. - Added validationTaskForIngestionUpdate to tasksMockData for testing purposes. - Adjusted Dirent type in fsService.spec.ts for improved type safety. Co-authored-by: Copilot <copilot@github.com>
…obHandler and FSService
CL-SHLOMIKONCHA
requested changes
May 18, 2026
Co-authored-by: Copilot <copilot@github.com>
…teJobHandler Co-authored-by: Copilot <copilot@github.com>
…nd update related imports in TileDeletionTaskManager Co-authored-by: Copilot <copilot@github.com>
…ap-colonies/mc-utils to version 6.0.0
CL-SHLOMIKONCHA
requested changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: #MAPCO-5735
This pull request introduces several enhancements and refactors to support a new report storage provider, improve S3 integration, and add new ingestion task types. The most significant changes include configuration and infrastructure updates for report storage, the addition of a new tile deletion ingestion task, and improvements to error handling and external service integration.
Storage Provider and S3 Integration:
reportStorageProvideroption in configuration files (config/default.json,config/custom-environment-variables.json) and Helm charts (helm/templates/configmap.yaml,helm/values.yaml) to allow the selection of storage backends for reports, similar to existing GPKG and tile storage providers. [1] [2] [3] [4]StorageProvidertype insrc/common/constants.tsto use values from@map-colonies/raster-shared, ensuring consistency across the codebase. [1] [2] [3]Ingestion Task Enhancements:
tilesDeletioningestion task type, including configuration options (type,tileBatchSize,taskBatchSize) and corresponding TypeScript interfaces. [1] [2] [3]TileDeletionTaskManager, ensuring deletion tasks are processed before merge tasks. [1] [2] [3]Dependency and Infrastructure Updates:
@map-colonies/raster-sharedpackage to version8.1.0-alpha.3, enabling new features and types.unziputility to the Docker image to support expanded data handling requirements.Error Handling and External Service Integration:
IntersectionErrorclass for improved error reporting when handling intersection operations with the polygon parts manager.PolygonPartsMangerClientto support intersection requests, including error handling and logging for intersection failures. [1] [2]