Improve docstrings and variables name in mobject.py#4674
Open
GoThrones wants to merge 8 commits intoManimCommunity:mainfrom
Open
Improve docstrings and variables name in mobject.py#4674GoThrones wants to merge 8 commits intoManimCommunity:mainfrom
GoThrones wants to merge 8 commits intoManimCommunity:mainfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…tps://github.com/GoThrones/ManimCE into improve_docstrings_and_variable_names_in_mobject
for more information, see https://pre-commit.ci
Contributor
Author
|
This CI failure appears to be an upstream TinyTeX URL issue, not related to this PR's changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR changes the docstrings at many places in mobject.py. At a few places, it improves the names of variables.
Motivation and Explanation: Why and how do your changes improve the library?
At some places the docstrings were not properly explained. At few places the docstrings were non-existent. Some of the variable names were not explicit. At one place, name of the method has been improved: Name of method set_z_index_by_z_Point3D has been improved to set_z_index_by_z_coordinate.
Reviewer Checklist