renamed fade_to to fade_to_color and added docstring to method: fade_to_color and method: fade#4665
Open
GoThrones wants to merge 2 commits intoManimCommunity:mainfrom
Open
renamed fade_to to fade_to_color and added docstring to method: fade_to_color and method: fade#4665GoThrones wants to merge 2 commits intoManimCommunity:mainfrom
GoThrones wants to merge 2 commits intoManimCommunity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR renames the method fade_to to fade_to_color and adds docstrings to the methods: fade_to, fade and get_num_points.
Motivation and Explanation: Why and how do your changes improve the library?
There was no docstring in either of the above mentioned methods and also, the name of the method: fade_to seemed somehow incomplete. It wasn't clear what is being faded by this method. The renamed method is fade_to_color. It makes it clear to understand that only the color is being changed.
Reviewer Checklist