-
Notifications
You must be signed in to change notification settings - Fork 4
Experimental: Sparse data #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add move data setter Fix some conversion warnings
ThomasKroes
approved these changes
Jan 20, 2025
Contributor
ThomasKroes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution seems to work for me on Windows 11. Tried 10 projects with data and they all load without issues.
ThomasKroes
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add initial sparse matrix implementation * Fix issue with reading in sparse data from project files * Add fromValue * Add getters and setters * Move Sparse Data into Experimental Nested Points class * Move templated code to header file * Use uint32 instead of uint16, float instead of uint16 Add move data setter Fix some conversion warnings * Some serialization steps are common * Fix pointer error * Consistent API * Return empty vec for dense getRow * Set dense data empty when setting sparse data * Template row index in sparse data and use size_t instead of uint for col index * Fix template compilation issue * Fix comment [skip ci] --------- Co-authored-by: Julian Thijssen <julianthijssen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the
SparseMatriximplementation from #556 but moves it into anExperimentalclass to clearly discourage usage since the sparse data API will change.You may use it right now like this:
Additions on top of #556:
size_tinstead ofuint16_tfor index typefloatinstead ofuint16_tfor data typeOne usage example is in the HDF5 loader where we currently
locksparse data since no other plugins support it yet.