Address PR review feedback: DRY violations, error handling, and sanitizer edge cases#7
Merged
Merged
Conversation
5 tasks
…ction methods Co-authored-by: MaksimShevtsov <20194438+MaksimShevtsov@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add inline SQL support with configurable sanitization
Address PR review feedback: DRY violations, error handling, and sanitizer edge cases
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 8 review comments on the inline SQL support PR covering code duplication, inconsistent error handling, and sanitizer gaps for SQL dialect-specific syntax.
Core fixes
_resolve_sql: Moved fromengine.pyandtransaction.pytoparams.pyas sharedresolve_sql()functionadapter.executein try-except to raiseParameterBindingErrorwith label context, matching engine behaviorSQLRegistry._load()to prevent ambiguity with inline SQL detectionSanitizer robustness
Extended
_tokenize()to handle SQL dialect-specific quoting:"name"): PostgreSQL, MySQL ANSI_QUOTES mode`name`): MySQL standardSQLSanitizationErrorfor unclosed strings/identifiersDocumentation
SQLSanitizerdocstring with unsafe/safe examples:name(registry) vs?(inline SQL) distinction incoerce_params()All changes maintain backward compatibility.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.