Fix race conditions on loop._ready_len#721
Merged
fantix merged 1 commit intoMagicStack:masterfrom Jan 19, 2026
Merged
Conversation
_ready_lenloop._ready_len
Contributor
Author
|
The test failure looks like a load on CI/CD. Compared to #719, some jobs run faster, some run at the same speed, and some run slower. The problem with |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple PR that fixes #720 by removing
loop._ready_lenin favor oflen(loop._ready). The attribute was probably added as a premature optimization (it does not affect performance even in edge cases), but it leads to race conditions both between worker threads callingloop.call_soon_threadsafe()and between any such worker thread and the event loop, sinceloop._ready_lenis updated in a non-thread-safe manner (free-threading).