Skip to content

fix(weather): reorder daily forecast columns#4118

Open
MannXo wants to merge 3 commits intoMagicMirrorOrg:developfrom
MannXo:fix/4117-weather-forecast-column-order
Open

fix(weather): reorder daily forecast columns#4118
MannXo wants to merge 3 commits intoMagicMirrorOrg:developfrom
MannXo:fix/4117-weather-forecast-column-order

Conversation

@MannXo
Copy link
Copy Markdown

@MannXo MannXo commented Apr 21, 2026

The daily forecast currently shows columns in this order: condition, max temp, min temp, precip amount, precip probability, UV Index. This is inconsistent with the order requested in the issue.

This PR reorders the daily forecast columns to: condition, min temp (low), max temp (high), UV Index, precip amount, precip probability.

Fixes #4117

@KristjanESPERANTO
Copy link
Copy Markdown
Collaborator

Thanks for the PR! Can you attach a before and after screenshot?

@rejas
Copy link
Copy Markdown
Collaborator

rejas commented Apr 22, 2026

I am not sure if changing the order is a good idea. Our users are used to how this is ordered now, changing it might confuse some...

But I am willing to see the change in screenshots, before making up my mind finally...

@KristjanESPERANTO
Copy link
Copy Markdown
Collaborator

@MannXo Did you noticed the request for screenshots? 🙂

@MannXo
Copy link
Copy Markdown
Author

MannXo commented May 4, 2026

@KristjanESPERANTO thank you for the reminder.
the before after screenshots are attached.
after
before

@KristjanESPERANTO
Copy link
Copy Markdown
Collaborator

@MannXo Thanks for the screenshots 🙂 Please mark which is which. I think the first is the "after" one, right?

@MannXo
Copy link
Copy Markdown
Author

MannXo commented May 5, 2026

@KristjanESPERANTO indeed.
First one is the "after" and second one is "before"

@KristjanESPERANTO KristjanESPERANTO requested a review from rejas May 6, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants