Add Weather API Provider #4036
Conversation
KristjanESPERANTO
left a comment
There was a problem hiding this comment.
Thanks for implementing this new provider! I found some little issues during testing. Checkout the comments.
The module works with my changes 😃
| weather.minTemperature = parseFloat(fd.day.mintemp_c); | ||
| weather.maxTemperature = parseFloat(fd.day.maxtemp_c); | ||
| weather.humidity = parseFloat(h.humidity); | ||
| weather.windSpeed = fd.day.maxwind_kph * 0.2778; |
There was a problem hiding this comment.
| weather.windSpeed = fd.day.maxwind_kph * 0.2778; | |
| weather.windSpeed = parseFloat(h.wind_kph) * 0.2778; |
I’d suggest using the hourly wind value (wind_kph) for each hourly forecast entry instead of the daily max wind.
Using the daily max can make hourly rows look too similar and less realistic, while the hourly value should better reflect how wind changes throughout the day.
There was a problem hiding this comment.
You marked this as resolved, but I don't see any change. Or do you think my suggestion is wrong?
There was a problem hiding this comment.
Ah, now I see you changed it to weather.windSpeed = parseFloat(fd.day.maxwind_kph) * 0.2778;
but would'nt weather.windSpeed = parseFloat(h.wind_kph) * 0.2778; be better?
|
All requested changes were fixed now, @KristjanESPERANTO. Please take a look. Question: Do you want me to make another PR to the |
The master branch is only for releases. So your change will only be included in the next release. The next release will be on April 1. |
Added Weather Provider for Weather API
Implementation of a weather provider for a new REST API.
Pull Requests:
APIs used
Config examples:
Screenshots