move custom.css from css to config#4020
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Jan 28, 2026
Merged
Conversation
Collaborator
|
Perhaps instead of automatically moving it, outputting a deprecation warning if custom.css is still in its old location? This would have the advantage that users would have to do this consciously by themself. |
Collaborator
Author
|
I don't care at all; I've implemented the most convenient solution for now. Let the majority decide. A warning is already displayed; you can change the text, abort with an error message, or... |
Collaborator
|
I’m ok with moving it. And moving if detected in old place |
rejas
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another change to cleanup structure, already mentioned in #4019 (comment)
After separating default and 3rd-party modules this PR moves the
custom.cssfrom the mm-owned directorycssinto user owned directoryconfig.It has a built-in function which moves the
css/custom.cssto the new locationconfig/custom.css(if the target not exists).Let me know if there's a majority in favor of this change.