Skip to content

update configuration section and add secrets#358

Merged
sdetweil merged 7 commits intoMagicMirrorOrg:developfrom
khassel:config
Feb 15, 2026
Merged

update configuration section and add secrets#358
sdetweil merged 7 commits intoMagicMirrorOrg:developfrom
khassel:config

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Feb 9, 2026

Changes for MagicMirrorOrg/MagicMirror#4029 and MagicMirrorOrg/MagicMirror#4033

  • remove config templating stuff
  • add variables in config.js
  • add new file about secrets

@KristjanESPERANTO
Copy link
Contributor

Nice! I just added my review fixes as commits and also handled up the cspell issues.

Copy link
Contributor

@KristjanESPERANTO KristjanESPERANTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But let's at least one other person have a look :-)

@khassel
Copy link
Collaborator Author

khassel commented Feb 14, 2026

I killed my pc yesterday so I might be unresponsive on several platforms for another few days ...

@KristjanESPERANTO
Copy link
Contributor

Good to know. Good luck with the repair 🤞

@sdetweil sdetweil merged commit 2b9042e into MagicMirrorOrg:develop Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants