Skip to content

Conversation

@rejas
Copy link
Collaborator

@rejas rejas commented Jan 24, 2026

No description provided.

@rejas rejas mentioned this pull request Jan 24, 2026
@rejas rejas marked this pull request as ready for review January 25, 2026 08:20
Copy link
Contributor

@KristjanESPERANTO KristjanESPERANTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Can .vuepress/config.js also be deleted?

@rejas
Copy link
Collaborator Author

rejas commented Jan 25, 2026

Fixed first round of issues.

Will convert to draft since I want to clean up the internal links, there are some inconsistencies

@rejas rejas marked this pull request as draft January 25, 2026 10:31
@rejas rejas marked this pull request as ready for review January 25, 2026 21:29
Copy link
Contributor

@KristjanESPERANTO KristjanESPERANTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this migration! 😃

@KristjanESPERANTO KristjanESPERANTO merged commit 7c4ec7b into MagicMirrorOrg:master Jan 25, 2026
1 check passed
@khassel
Copy link
Collaborator

khassel commented Jan 25, 2026

the container build fails

cp: can't stat 'MagicMirror-Documentation/.vuepress/dist': No such file or directory

so I assume the output dir has changed, where are the static files now after build and has the build command changed too?

current (excerpt):

      git clone --depth 1 -b $REPO_BRANCH --single-branch "https://github.com/MagicMirrorOrg/MagicMirror-Documentation.git"
      cd MagicMirror-Documentation
      git log -1
      npm install
      node --run docs:build
  artifacts:
    paths:
      - MagicMirror-Documentation/.vuepress/dist/

@rejas rejas deleted the vitepress branch January 25, 2026 21:57
@rejas
Copy link
Collaborator Author

rejas commented Jan 25, 2026

so I assume the output dir has changed

Correct, the output is now under ".vitepress/dist".

@khassel
Copy link
Collaborator

khassel commented Jan 25, 2026

new docs are online meanwhile, other question, for what is this grey area on each site? Or are there advertises (which are filtered out on my side)?

grafik

@KristjanESPERANTO
Copy link
Contributor

for what is this grey area on each site? Or are there advertises (which are filtered out on my side)?

Yes, it's for the Carbon Ads. I've created #350 to make the background of the area invisible - this doesn't deactivate the ads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants