Refactoring #5
Open
Refactoring #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffferent partials files have been created and imported and the main stylesheet. The sidebar has been set as an aside element. Some modificaitons have been made, and the script has been updated. The BEM methodology have been used with unique ID used as CSS selector, for the header section. The stylesheet has been cleaned for the header section.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A README.md file has been added to briefly describe the project.
Contributor
Author
|
A README.md file has been added. |
The generation of the progress bars have been externalized in a JavaScript file, which can generate new progression bars dynamically by adding new value in the dedicated object. A new partial has been created for the about section. Half of it has been modified using the BEM methodology.
Contributor
Author
|
Don"t worry about merging. The README.md contains a link to the legacy code. |
The label of each skill, corresponding to a technology, have been changed to a icon. It is dynamically rendered through JavaScript.
Contributor
Author
|
I didn't create a loader for the item from the timeline with JavaScript, because each item's content could be stylized differently, and is also more static. |
The identifiers and classes have been modified following the BEM methodology. The icons have been fixed and Font Awesome updated. New mixins have been added. Useless HTML and CSS have been removed.
Colors for the controls have been slightly modified in order to have a better contrast.
Contributor
Author
|
The project has been totally refactored for the desktop version. The scripts includes (very basic) IIFEs rendering part of the HTML, using the data from the dedicated objects from the files in the data folder. The elements are generated using the DOM's document's methods. A lighter approach could be use to generate the HTML through a interpolated string instead. |
Media queries have been added. The display of the blog section and the portfolio have been changed, with fixed sized, in order to avoid unwanted ratio when changing the screen size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diffferent partials files have been created and imported and the main stylesheet.
The sidebar has been set as an aside element. Some modificaitons have been made, and the script has been updated.
The BEM methodology have been used with unique ID used as CSS selector, for the header section.
The stylesheet has been cleaned for the header section.