Seed sphere creation fix

[nolt]

Fixes: #767

BUG: Seed Sphere Assembly does not allow placing items

Description:
When a player talks to the Seed Master NPC in Elveland and selects "Seed Sphere
Assembly" (Seed Sphere Creation, crafting 43), then tries to put the required
items (Seed, Sphere, Jewel of Creation, Jewel of Chaos) into the crafting
dialog, the NPC does not allow placing any items.

Root cause:
In MoveItemAction.cs, method IsStorageContextAllowed, the SeedSphereCrafting
storage is checked against NpcWindow.SeedResearcher. However, the "Seed Sphere
Assembly" dialog is opened by the Seed Master NPC (NpcWindow.SeedMaster), not
by the Seed Researcher.

As a result, when the player has the Seed Master window open (correct for this
dialog) and tries to move an item to the SeedSphereCrafting storage, the server
rejects the move because it expects the Seed Researcher window to be open.

The SocketSystem.cs initialization confirms the crafting assignments:

• Seed Master (NpcWindow.SeedMaster) has crafting 42 (Seed Creation)
  and crafting 43 (Seed Sphere Creation)
• Seed Researcher (NpcWindow.SeedResearcher) has crafting 44
  (Mount Seed Sphere) and crafting 45 (Remove Seed Sphere)

In MoveItemAction.cs, line 424:
Storages.SeedCrafting => ... NpcWindow.SeedMaster // correct
Storages.SeedSphereCrafting => ... NpcWindow.SeedResearcher // BUG!

Fix:
In src/GameLogic/PlayerActions/Items/MoveItemAction.cs, line 424, change:
NpcWindow.SeedResearcher -> NpcWindow.SeedMaster

After the fix:
Storages.SeedSphereCrafting => state == PlayerState.NpcDialogOpened
&& openedWindow == NpcWindow.SeedMaster,

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where players were unable to place items into the Seed Sphere Assembly crafting dialog. By updating the storage context validation, the server now correctly recognizes the Seed Master NPC as the authorized entity for this specific crafting process, resolving the interaction failure.

Highlights

• Seed Sphere Assembly Fix: Corrected the NPC window validation for Seed Sphere Assembly to reference the Seed Master instead of the Seed Researcher.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the IsStorageContextAllowed method in MoveItemAction.cs to change the required NPC window for SeedSphereCrafting from SeedResearcher to SeedMaster. I have no feedback to provide as there are no review comments to evaluate.