GWDO2026: Revisions in gravity wave drag scheme (bl_gwdo.F90)#1409
GWDO2026: Revisions in gravity wave drag scheme (bl_gwdo.F90)#1409Songyou184 wants to merge 12 commits into
Conversation
modified: core_atmosphere/Registry.xml modified: core_atmosphere/physics/mpas_atmphys_driver_gwdo.F modified: core_atmosphere/physics/mpas_atmphys_driver_sfclayer.F modified: core_atmosphere/physics/mpas_atmphys_vars.F modified: core_atmosphere/physics/physics_wrf/module_bl_gwdo.F modified: core_atmosphere/physics/physics_wrf/module_sf_sfclayrev.F
deleted: core_atmosphere/physics/physics_wrf/module_sf_sfclayrev.F
new file: mpas_atmphys_driver_sfclayer.F new file: physics_wrf/module_sf_sfclayrev.F
modified: src/core_atmosphere/physics/mpas_atmphys_driver.F
…nto GWDO2026 merge branch
jihyeonjang
left a comment
jihyeonjang
left a comment
There was a problem hiding this comment.
As I mentioned in my comments on Externals.cfg, I think it would be better to use the public MMM-physics repository, if possible.
In this regards, if we use the latest tag of NCAR/MMM-physics, would 20260319-WRFv4.8.0 tag be the appropriate one for this PR, or would it be better to wait for the upcoming tag? If the new tag is more appropriate, could you let me know when it is expected to be available?
Also, could you confirm whether the new tag, or 20260319-WRFv4.8.0, will include the changes made by @Songyou184 in this PR, as well as his changes in other PRs (#1410, #1411)?
I am adding @weiwangncar @dudhia for more input. Thank you!
| protocol = git | ||
| repo_url = https://github.com/NCAR/MMM-physics.git | ||
| tag = 20250616-MPASv8.3 | ||
| repo_url = https://github.com/songyou184/MMM-physics.git |
There was a problem hiding this comment.
This is a private repository rather than the public MMM-physics repository. If possible, I think the branch/tag specified in Externals.cfg should be from https://github.com/NCAR/MMM-physics.git.
There was a problem hiding this comment.
@jihyeonjang Since bl_gwdo.F90 in MMM-physics has recently updated, it is now ok to point to that repository. But it may need to update the hash to access the newest code.
| sina_p !sine of map rotation [-] | ||
|
|
||
| real(kind=RKIND),dimension(:,:),allocatable:: & | ||
| ter_p, &!orographic height [m] |
There was a problem hiding this comment.
ter_p can be deleted? It does not appear to be used anywhere.
| <nml_option name="config_gwdo_nonhyd" type="logical" default_value="true" in_defaults="true" | ||
| units="-" | ||
| description="Logical index for nonhydrostatic effect in kim_gwdo scheme" | ||
| possible_values="true. or .false."/> |
There was a problem hiding this comment.
For possible_values, "." is needed before true, so it should be:
possible_values=".true. or .false."
| units="-" | ||
| description="Effective grid length ratio in kim_gwdo scheme" | ||
| possible_values="Non-negative real values"/> | ||
| <nml_option name="config_gwdo_nonhyd" type="logical" default_value="true" in_defaults="true" |
There was a problem hiding this comment.
Is it okay to set in_defaults="false" so that config_gwdo_nonhyd is set to true automatically and does not need to be specified by users in namelist.atmosphere, similar to the other physics options?
3 participants
This PR is a part of Revised GWDO + new PBL option for SHIN-HONG scheme #1389
Testing and relations to other Pull Requests should be added as subsequent comments.
See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931