feat: tolerate unknown options#2809
Draft
wpbonelli wants to merge 2 commits into
Draft
Conversation
mjreno
reviewed
May 26, 2026
| this%mf6_input%subcomponent_type, & | ||
| this%mf6_input%block_dfns(iblk)%blockname, & | ||
| tag, this%filename) | ||
| if (itolerate_unknown == 1) then |
Contributor
There was a problem hiding this comment.
This isn't specific to the OPTIONS block you would also need to check the block here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a keyword option
TOLERATE_UNKNOWNto the simulation, defaulting false. If present, unrecognized options will not stop the simulation with an error, rather the simulation will continue with a warning.Motivated by modflowpy/flopy#2710. Alternative and/or complimentary solution to modflowpy/flopy#2712. Still TBD what to do here.
Checklist of items for pull request
ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettify