Updates to Chrome and Firefox Extensions #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manifest V3 Updates:
- Replace `background.page` with `background.service_worker` and point it to `background.js`
- Remove `background.html` as it's not necessary
- Move URL Permissions to `optional_host_permissions`
- Updates to `background.js`:
- Change `getClickHandler` to Object Function
- Replace `escape` with `encodeURIComponent` since `escape` is deprecated
- Assign the context menu an ID as is required by Manifest V3
- Add EventListener for context menu item click
Unrelated to V3:
- Formatting
- Variable declarations
Firefox's implementation of Manifest V3 has some slight deviations for Chrome so for now we need a version with a Manifest specific to Firefox
bradchoate
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.