Add CODEOWNERS and update dependencies #46
Conversation
| # to indicate the primary expert for this code. | ||
| # * @ghukill | ||
|
|
||
| # Teams can be specified as code owners as well. Teams should be identified in |
There was a problem hiding this comment.
@ghukill It might be worth adding a line specifying that the workflows should be linked to InfraEng..
There was a problem hiding this comment.
@cabutlermit - Happy to add, but do you think it's more true for this repository than others? does adding it here imply we should be adding InfraEng globally to CODEOWNERS files?
There was a problem hiding this comment.
Ha! I should have been more specific and more detailed in my comment. I'm picturing lines like this in CODEOWNERS, at least in this repo and maybe in other repos that have GHA workflows that publish apps to ECR in AWS.
/.github/dev-* @mitlibraries/infraeng
/.github/stage-* @mitlibraries/infraeng
/.github/prod-* @mitlibraries/infraeng
Or, maybe this would do it (I think that later lines override earlier lines):
/.github/* @mitlibraries/infraeng
/.github/ci.yml @mitlibraries/dataeng
That way, if anyone ever makes changes to those workflow files and PR's those changes, InfraEng will automatically get tagged for review.
There was a problem hiding this comment.
@cabutlermit - Ahhhhh! Makes sense, love it. Thanks for the clarification. I don't have very strong CODEOWNERS intuition yet, but appreciating this per-file-pattern approach and the implications there. Will add.
There was a problem hiding this comment.
New commit here: 88dc80d. Review re-requested.
2 participants
Purpose and background context
This PR updates dependencies for a v1 production tagged release.
Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review